netdev - Re: [PATCH net 2/4] net: wwan: iosm: fix dma_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y36XniABNqw+7NNO@eldamar.lan>
Date:   Wed, 23 Nov 2022 22:58:54 +0100
From:   Salvatore Bonaccorso <carnil@...ian.org>
To:     m.chetan.kumar@...ux.intel.com
Cc:     netdev@...r.kernel.org, kuba@...nel.org, davem@...emloft.net,
        johannes@...solutions.net, ryazanov.s.a@...il.com,
        loic.poulain@...aro.org, linuxwwan@...el.com, edumazet@...gle.com,
        pabeni@...hat.com, didi.debian@...ow.org
Subject: Re: [PATCH net 2/4] net: wwan: iosm: fix dma_alloc_coherent
 incompatible pointer type

Hi,

On Tue, Nov 22, 2022 at 11:16:57PM +0530, m.chetan.kumar@...ux.intel.com wrote:
> From: M Chetan Kumar <m.chetan.kumar@...ux.intel.com>
> 
> Fix build error reported on armhf while preparing 6.1-rc5
> for Debian.
> 
> iosm_ipc_protocol.c:244:36: error: passing argument 3 of
> 'dma_alloc_coherent' from incompatible pointer type.
> 
> Change phy_ap_shm type from phys_addr_t to dma_addr_t.
> 
> Fixes: faed4c6f6f48 ("net: iosm: shared memory protocol")
> Reported-by: Bonaccorso Salvatore <carnil@...ian.org>
> Signed-off-by: M Chetan Kumar <m.chetan.kumar@...ux.intel.com>
> ---
>  drivers/net/wwan/iosm/iosm_ipc_protocol.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wwan/iosm/iosm_ipc_protocol.h b/drivers/net/wwan/iosm/iosm_ipc_protocol.h
> index 9b3a6d86ece7..289397c4ea6c 100644
> --- a/drivers/net/wwan/iosm/iosm_ipc_protocol.h
> +++ b/drivers/net/wwan/iosm/iosm_ipc_protocol.h
> @@ -122,7 +122,7 @@ struct iosm_protocol {
>  	struct iosm_imem *imem;
>  	struct ipc_rsp *rsp_ring[IPC_MEM_MSG_ENTRIES];
>  	struct device *dev;
> -	phys_addr_t phy_ap_shm;
> +	dma_addr_t phy_ap_shm;
>  	u32 old_msg_tail;
>  };

The patch resolves the build failure we did notice. Only was able to
test the build though, no functional test on armhf.

Regards,
Salvatore