netdev - Re: [net 04/14] net/mlx5: cmdif, Print info on any firmware cmd failure to tracepoint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y36xN31vRfajwzgb@x130.lan>
Date:   Wed, 23 Nov 2022 15:48:07 -0800
From:   Saeed Mahameed <saeed@...nel.org>
To:     Maciej Fijalkowski <maciej.fijalkowski@...el.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Saeed Mahameed <saeedm@...dia.com>, netdev@...r.kernel.org,
        Tariq Toukan <tariqt@...dia.com>,
        Moshe Shemesh <moshe@...dia.com>,
        Shay Drory <shayd@...dia.com>, Maor Gottlieb <maorg@...dia.com>
Subject: Re: [net 04/14] net/mlx5: cmdif, Print info on any firmware cmd
 failure to tracepoint

On 23 Nov 16:06, Maciej Fijalkowski wrote:
>On Mon, Nov 21, 2022 at 06:25:49PM -0800, Saeed Mahameed wrote:
>> From: Moshe Shemesh <moshe@...dia.com>
>>
>> While moving to new CMD API (quiet API), some pre-existing flows may call the new API
>> function that in case of error, returns the error instead of printing it as previously done.
>> For such flows we bring back the print but to tracepoint this time for sys admins to
>> have the ability to check for errors especially for commands using the new quiet API.
>>
>
>WARNING: Possible unwrapped commit description (prefer a maximum 75 chars
>per line)
>

we don't enforce this in netdev, especially when you want to share output,
etc .. 

also for future reference in mlx5 we allow up to 95 chars per code line, we
got wide screens :P, so also please ignore these warnings.

chkpatch = "!./scripts/checkpatch.pl --max-line-length=95 --strict --show-types --ignore COMMIT_LOG_LONG_LINE,FILE_PATH_CHANGES,MACRO_ARG_REUSE,MACRO_ARG_PRECEDENCE"