netdev - Re: [net 13/14] net/mlx5e: Fix MACsec update SecY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y36zU4/dv9wwMGmg@x130.lan>
Date:   Wed, 23 Nov 2022 15:57:07 -0800
From:   Saeed Mahameed <saeed@...nel.org>
To:     Maciej Fijalkowski <maciej.fijalkowski@...el.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Saeed Mahameed <saeedm@...dia.com>, netdev@...r.kernel.org,
        Tariq Toukan <tariqt@...dia.com>,
        Emeel Hakim <ehakim@...dia.com>, Raed Salem <raeds@...dia.com>
Subject: Re: [net 13/14] net/mlx5e: Fix MACsec update SecY

On 23 Nov 16:21, Maciej Fijalkowski wrote:
>On Mon, Nov 21, 2022 at 06:25:58PM -0800, Saeed Mahameed wrote:
>> From: Emeel Hakim <ehakim@...dia.com>
>>
>> Currently updating SecY destroys and re-creates RX SA objects,
>> the re-created RX SA objects are not identical to the destroyed
>> objects and it disagree on the encryption enabled property which
>
>nit: disagrees?
>

I think this is minor, let's be considerate, many contributors are non
native english speakers, so as long as the commit message is
understandable and sound, i think we should just ignore such simple
mistakes. We are not here to review proper grammar..