lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20221123175550.126c7180@kernel.org>
Date:   Wed, 23 Nov 2022 17:55:50 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Saeed Mahameed <saeed@...nel.org>
Cc:     Maciej Fijalkowski <maciej.fijalkowski@...el.com>,
        "David S. Miller" <davem@...emloft.net>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Saeed Mahameed <saeedm@...dia.com>, netdev@...r.kernel.org,
        Tariq Toukan <tariqt@...dia.com>,
        Moshe Shemesh <moshe@...dia.com>,
        Shay Drory <shayd@...dia.com>, Maor Gottlieb <maorg@...dia.com>
Subject: Re: [net 04/14] net/mlx5: cmdif, Print info on any firmware cmd
 failure to tracepoint

On Wed, 23 Nov 2022 15:48:07 -0800 Saeed Mahameed wrote:
> >> While moving to new CMD API (quiet API), some pre-existing flows may call the new API
> >> function that in case of error, returns the error instead of printing it as previously done.
> >> For such flows we bring back the print but to tracepoint this time for sys admins to
> >> have the ability to check for errors especially for commands using the new quiet API.
> >
> > WARNING: Possible unwrapped commit description (prefer a maximum 75 chars
> > per line)
> 
> we don't enforce this in netdev, especially when you want to share output,
> etc .. 

Maciej is right, it's one of those things I don't have stamina to
enforce. But you just gave me motivation, please start complying with
the rules.

> also for future reference in mlx5 we allow up to 95 chars per code line, we
> got wide screens :P, so also please ignore these warnings.

"We got wide screens"? Your inability to write concise code is
certainly not a virtue. Don't be flippant about it :/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ