netdev - Re: [PATCH net-next] selftests/net: add csum offload test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 28 Nov 2022 17:08:48 +0100
From:   Paolo Abeni <pabeni@...hat.com>
To:     Willem de Bruijn <willemdebruijn.kernel@...il.com>,
        netdev@...r.kernel.org
Cc:     davem@...emloft.net, kuba@...nel.org, edumazet@...gle.com,
        Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH net-next] selftests/net: add csum offload test

Hi,

On Mon, 2022-11-28 at 09:02 -0500, Willem de Bruijn wrote:
> From: Willem de Bruijn <willemb@...gle.com>
> 
> Test NIC hardware checksum offload:
> 
> - Rx + Tx
> - IPv4 + IPv6
> - TCP + UDP
> 
> Optional features:
> 
> - zero checksum 0xFFFF
> - checksum disable 0x0000
> - transport encap headers
> - randomization
> 
> See file header for detailed comments.
> 
> Expected results differ depending on NIC features:
> 
> - CHECKSUM_UNNECESSARY vs CHECKSUM_COMPLETE
> - NETIF_F_HW_CSUM (csum_start/csum_off) vs NETIF_F_IP(V6)_CSUM
> 
> Signed-off-by: Willem de Bruijn <willemb@...gle.com>

I'm wondering if we could hook this into the self-tests list with a
suitable wrapper script, e.g. searching for a NIC exposing the loopback
feature, quering the NETIF_F_HW_CSUM/NETIF_F_IP(V6)_CSUM bit via
ethtool and guessing CHECKSUM_UNNECESSARY vs CHECKSUM_COMPLETE via the
received packet.

If the host lacks a suitable device, the test is skipped. WDYT?

Thanks!

Paolo