netdev - Re: [RFC PATCH] net: devlink: devlink_nl_info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 29 Nov 2022 08:14:06 +0900
From:   Vincent MAILHOL <mailhol.vincent@...adoo.fr>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Jiri Pirko <jiri@...dia.com>, netdev@...r.kernel.org,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH] net: devlink: devlink_nl_info_fill: populate default information

On Tue. 29 Nov. 2022 at 03:43, Jakub Kicinski <kuba@...nel.org> wrote:
> On Thu, 24 Nov 2022 14:33:58 +0900 Vincent MAILHOL wrote:
> > > I think 2/ is best because it will generalize to serial numbers while
> > > 1/ will likely not. 3/ is a smaller gain.
> > >
> > > Jiri already plumbed thru the struct devlink_info_req which is on the
> > > stack of the caller, per request, so we can add the bool / bitmap for
> > > already reported items there quite easily.
> >
> > Sorry, let me clarify the next actions. Are you meaning that Jiri is
> > already working on the bitmap implementation and should I wait for his
> > patches first? Or do you expect me to do it?
>
> Dunno if the question still stands but we already have
> struct devlink_info_req and can put the bitmap in it.
> All drivers use devlink helpers to add attributes.

Roger that. I already wrote the code, I just need to do a bit of
ironing and extra testing. I will send it after the "net: devlink:
devlink_nl_info_fill: populate default information" series gets
merged.