netdev - Re: [PATCH v4 net-next 1/2] net: phy: micrel: Fixed error related to uninitialized symbol ret

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y43z8+grm/TM3ype@lunn.ch>
Date:   Mon, 5 Dec 2022 14:36:51 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Divya Koppera <Divya.Koppera@...rochip.com>
Cc:     hkallweit1@...il.com, linux@...linux.org.uk, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        richardcochran@...il.com, UNGLinuxDriver@...rochip.com,
        Madhuri.Sripada@...rochip.com
Subject: Re: [PATCH v4 net-next 1/2] net: phy: micrel: Fixed error related to
 uninitialized symbol ret

On Mon, Dec 05, 2022 at 04:05:49PM +0530, Divya Koppera wrote:
> Initialized return variable
> 
> Fixes Old smatch warnings:
> drivers/net/phy/micrel.c:1750 ksz886x_cable_test_get_status() error:
> uninitialized symbol 'ret'.

I guess this patch has been rebased without the smatch warning being
changed because line 1750 in net-next/main is a blank line between two
functions.

> Reported-by: kernel test robot <lkp@...el.com>
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Fixes: 21b688dabecb ("net: phy: micrel: Cable Diag feature for lan8814 phy")
> Signed-off-by: Divya Koppera <Divya.Koppera@...rochip.com>

So once i looked in the correct place:

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew