netdev - Re: [PATCH net] net: thunderbolt: fix memory leak in tbnet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y430Od5z5gNI2p0G@black.fi.intel.com>
Date:   Mon, 5 Dec 2022 15:38:01 +0200
From:   Mika Westerberg <mika.westerberg@...ux.intel.com>
To:     Zhengchao Shao <shaozhengchao@...wei.com>
Cc:     netdev@...r.kernel.org, michael.jamet@...el.com,
        YehezkelShB@...il.com, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, weiyongjun1@...wei.com,
        yuehaibing@...wei.com
Subject: Re: [PATCH net] net: thunderbolt: fix memory leak in tbnet_open()

Hi,

On Mon, Dec 05, 2022 at 07:55:59PM +0800, Zhengchao Shao wrote:
> When tb_ring_alloc_rx() failed in tbnet_open(), it doesn't free ida.
> 
> Fixes: 180b0689425c ("thunderbolt: Allow multiple DMA tunnels over a single XDomain connection")
> Signed-off-by: Zhengchao Shao <shaozhengchao@...wei.com>
> ---
>  drivers/net/thunderbolt.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/thunderbolt.c b/drivers/net/thunderbolt.c
> index a52ee2bf5575..70fd61ce15c6 100644
> --- a/drivers/net/thunderbolt.c
> +++ b/drivers/net/thunderbolt.c
> @@ -916,6 +916,7 @@ static int tbnet_open(struct net_device *dev)
>  		netdev_err(dev, "failed to allocate Rx ring\n");
>  		tb_ring_free(net->tx_ring.ring);
>  		net->tx_ring.ring = NULL;
> +		tb_xdomain_release_out_hopid(xd, hopid);

Can you move this before tb_ring_free()? Like this:

  		netdev_err(dev, "failed to allocate Rx ring\n");
 		tb_xdomain_release_out_hopid(xd, hopid);
  		tb_ring_free(net->tx_ring.ring);
  		net->tx_ring.ring = NULL;

Otherwise looks good to me.