netdev - Re: [PATCH net] net: thunderbolt: fix memory leak in tbnet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 6 Dec 2022 08:46:52 +0800
From:   shaozhengchao <shaozhengchao@...wei.com>
To:     Mika Westerberg <mika.westerberg@...ux.intel.com>
CC:     <netdev@...r.kernel.org>, <michael.jamet@...el.com>,
        <YehezkelShB@...il.com>, <davem@...emloft.net>,
        <edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
        <weiyongjun1@...wei.com>, <yuehaibing@...wei.com>
Subject: Re: [PATCH net] net: thunderbolt: fix memory leak in tbnet_open()



On 2022/12/5 21:38, Mika Westerberg wrote:
> Hi,
> 
> On Mon, Dec 05, 2022 at 07:55:59PM +0800, Zhengchao Shao wrote:
>> When tb_ring_alloc_rx() failed in tbnet_open(), it doesn't free ida.
>>
>> Fixes: 180b0689425c ("thunderbolt: Allow multiple DMA tunnels over a single XDomain connection")
>> Signed-off-by: Zhengchao Shao <shaozhengchao@...wei.com>
>> ---
>>   drivers/net/thunderbolt.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/net/thunderbolt.c b/drivers/net/thunderbolt.c
>> index a52ee2bf5575..70fd61ce15c6 100644
>> --- a/drivers/net/thunderbolt.c
>> +++ b/drivers/net/thunderbolt.c
>> @@ -916,6 +916,7 @@ static int tbnet_open(struct net_device *dev)
>>   		netdev_err(dev, "failed to allocate Rx ring\n");
>>   		tb_ring_free(net->tx_ring.ring);
>>   		net->tx_ring.ring = NULL;
>> +		tb_xdomain_release_out_hopid(xd, hopid);
> 
> Can you move this before tb_ring_free()? Like this:
> 
>    		netdev_err(dev, "failed to allocate Rx ring\n");
>   		tb_xdomain_release_out_hopid(xd, hopid);
>    		tb_ring_free(net->tx_ring.ring);
>    		net->tx_ring.ring = NULL;
> 
> Otherwise looks good to me.
> 
Hi Mika:
	Thank you for your advice. I will send V2.

Zhengchao Shao