netdev - Re: [PATCH v2 net-next 4/4] drivers/net/phy: add driver for the onsemi NCN26000 10BASE-T1S PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202212051242.QII0tLqm-lkp@intel.com>
Date:   Mon, 5 Dec 2022 12:50:26 +0800
From:   kernel test robot <lkp@...el.com>
To:     Piergiorgio Beruto <piergiorgio.beruto@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
Cc:     oe-kbuild-all@...ts.linux.dev, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Oleksij Rempel <o.rempel@...gutronix.de>
Subject: Re: [PATCH v2 net-next 4/4] drivers/net/phy: add driver for the
 onsemi NCN26000 10BASE-T1S PHY

Hi Piergiorgio,

I love your patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Piergiorgio-Beruto/net-ethtool-add-netlink-interface-for-the-PLCA-RS/20221205-094500
patch link:    https://lore.kernel.org/r/fb10b2a22255d493c6e3abc330b6e3f5f28c495e.1670204277.git.piergiorgio.beruto%40gmail.com
patch subject: [PATCH v2 net-next 4/4] drivers/net/phy: add driver for the onsemi NCN26000 10BASE-T1S PHY
config: m68k-allmodconfig
compiler: m68k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/91aaf14d7c224d0b9883922a14086dd4c60da5f0
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Piergiorgio-Beruto/net-ethtool-add-netlink-interface-for-the-PLCA-RS/20221205-094500
        git checkout 91aaf14d7c224d0b9883922a14086dd4c60da5f0
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/net/phy/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from drivers/net/phy/ncn26000.c:11:
>> drivers/net/phy/ncn26000.c:184:27: error: 'ncn26000_tbl' undeclared here (not in a function); did you mean 'ncn26000_probe'?
     184 | MODULE_DEVICE_TABLE(mdio, ncn26000_tbl);
         |                           ^~~~~~~~~~~~
   include/linux/module.h:243:15: note: in definition of macro 'MODULE_DEVICE_TABLE'
     243 | extern typeof(name) __mod_##type##__##name##_device_table               \
         |               ^~~~
>> include/linux/module.h:243:21: error: '__mod_mdio__ncn26000_tbl_device_table' aliased to undefined symbol 'ncn26000_tbl'
     243 | extern typeof(name) __mod_##type##__##name##_device_table               \
         |                     ^~~~~~
   drivers/net/phy/ncn26000.c:184:1: note: in expansion of macro 'MODULE_DEVICE_TABLE'
     184 | MODULE_DEVICE_TABLE(mdio, ncn26000_tbl);
         | ^~~~~~~~~~~~~~~~~~~


vim +184 drivers/net/phy/ncn26000.c

   183	
 > 184	MODULE_DEVICE_TABLE(mdio, ncn26000_tbl);

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (276602 bytes)