netdev - Re: [PATCH net-next v2 1/3] net/sched: add retpoline wrapper for tc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANn89iL2Oyq3GhudP9FVawWyswYj+2QB0iQHKFf2GH8DZ8HeTg@mail.gmail.com>
Date:   Mon, 5 Dec 2022 05:56:52 +0100
From:   Eric Dumazet <edumazet@...gle.com>
To:     Pedro Tammela <pctammela@...il.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
        pabeni@...hat.com, jhs@...atatu.com, xiyou.wangcong@...il.com,
        jiri@...nulli.us, kuniyu@...zon.com,
        Pedro Tammela <pctammela@...atatu.com>
Subject: Re: [PATCH net-next v2 1/3] net/sched: add retpoline wrapper for tc

On Mon, Nov 28, 2022 at 4:45 PM Pedro Tammela <pctammela@...il.com> wrote:
>
> On kernels compiled with CONFIG_RETPOLINE and CONFIG_NET_TC_INDIRECT_WRAPPER,
> optimize actions and filters that are compiled as built-ins into a direct call.
> The calls are ordered alphabetically, but new ones should be ideally
> added last.
>
> On subsequent patches we expose the classifiers and actions functions
> and wire up the wrapper into tc.
>
> Signed-off-by: Pedro Tammela <pctammela@...atatu.com>
> ---


> +static inline int __tc_act(struct sk_buff *skb, const struct tc_action *a,
> +                          struct tcf_result *res)

Perhaps remove the __ prefix, since there is not yet an  __tc_act() and tc_act()

> +
> +static inline int __tc_classify(struct sk_buff *skb, const struct tcf_proto *tp,
> +                               struct tcf_result *res)

Same remark, the __ prefix seems not necessary.