netdev - Re: [PATCH v5 net-next 1/2] net: phy: micrel: Fixed error related to uninitialized symbol ret

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 6 Dec 2022 10:09:53 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Divya Koppera <Divya.Koppera@...rochip.com>
Cc:     andrew@...n.ch, hkallweit1@...il.com, linux@...linux.org.uk,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, richardcochran@...il.com,
        UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH v5 net-next 1/2] net: phy: micrel: Fixed error related to
 uninitialized symbol ret

Tue, Dec 06, 2022 at 08:35:10AM CET, Divya.Koppera@...rochip.com wrote:
>Initialized return variable

Not only here, but in the patch/patchset subject, you should be
imperative to the codebase and tell it what to do.


>
>Fixes Old smatch warnings:
>drivers/net/phy/micrel.c:1750 ksz886x_cable_test_get_status() error:
>uninitialized symbol 'ret'.
>
>Reported-by: kernel test robot <lkp@...el.com>
>Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
>Fixes: 21b688dabecb ("net: phy: micrel: Cable Diag feature for lan8814 phy")
>Reviewed-by: Andrew Lunn <andrew@...n.ch>
>Signed-off-by: Divya Koppera <Divya.Koppera@...rochip.com>
>---
>v4 -> v5:
>- No changes, added reviewed by tag.
>
>v3 -> v4:
>- Split the patch for different warnings.
>
>v1 -> v3:
>- No changes
>---
> drivers/net/phy/micrel.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
>index 26ce0c5defcd..1bcdb828db56 100644
>--- a/drivers/net/phy/micrel.c
>+++ b/drivers/net/phy/micrel.c
>@@ -2088,7 +2088,8 @@ static int ksz886x_cable_test_get_status(struct phy_device *phydev,
> 	const struct kszphy_type *type = phydev->drv->driver_data;
> 	unsigned long pair_mask = type->pair_mask;
> 	int retries = 20;
>-	int pair, ret;
>+	int ret = 0;
>+	int pair;
> 
> 	*finished = false;
> 
>-- 
>2.17.1
>