netdev - Re: [PATCH net] stmmac: fix potential division by 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87v8mne09m.fsf@kurt>
Date:   Wed, 07 Dec 2022 15:50:13 +0100
From:   Kurt Kanzenbach <kurt@...utronix.de>
To:     Andrew Lunn <andrew@...n.ch>, Jakub Kicinski <kuba@...nel.org>
Cc:     Piergiorgio Beruto <piergiorgio.beruto@...il.com>,
        netdev@...r.kernel.org, peppe.cavallaro@...com,
        Voon Weifeng <weifeng.voon@...el.com>,
        Rayagond Kokatanur <rayagond@...avyalabs.com>,
        Jose Abreu <Jose.Abreu@...opsys.com>,
        Antonio Borneo <antonio.borneo@...com>,
        Tan Tee Min <tee.min.tan@...el.com>
Subject: Re: [PATCH net] stmmac: fix potential division by 0

On Wed Dec 07 2022, Andrew Lunn wrote:
> On Tue, Dec 06, 2022 at 06:28:23PM -0800, Jakub Kicinski wrote:
>> On Thu, 1 Dec 2022 15:49:37 +0100 Andrew Lunn wrote:
>> > > The root cause is the MAC using the internal clock as a PTP reference
>> > > (default), which should be allowed since the connection to an external
>> > > PTP clock is optional from an HW perspective. The internal clock seems
>> > > to be derived from the MII clock speed, which is 2.5 MHz at 10 Mb/s.  
>> > 
>> > I think we need help from somebody who understands PTP on this device.
>> > The clock is clearly out of range, but how important is that to PTP?
>> > Will PTP work if the value is clamped to 0xff? Or should we be
>> > returning -EINVAL and disabling PTP because it has no chance of
>> > working?
>> 
>> Indeed, we need some more info here :( Like does the PTP actually
>> work with 2.5 MHz clock? The frequency adjustment only cares about 
>> the addend, what is sub_second_inc thing?
>
> Hi Jakub
>
> I Cc: many of the people who worked on PTP with this hardware, and
> nobody has replied.
>
> I think we should wait a couple more days, and then add a range check,
> and disable PTP for invalid clocks. That might provoke feedback.

Here's the Altera manual:

 https://www.intel.com/content/www/us/en/docs/programmable/683126/21-2/functional-description-of-the-emac.html

Table 183 shows the minimum PTP frequencies and also states "Therefore,
a higher PTP clock frequency gives better system performance.".

So, I'd say using a clock of 2.5MHz seems possible, but will result in
suboptimal precision.

Thanks,
Kurt

Download attachment "signature.asc" of type "application/pgp-signature" (862 bytes)