netdev - RE: [Intel-wired-lan] [PATCH intel-next v4] i40e: allow toggling loopback mode via ndo_set_features callback

Open Source and information security mailing list archives

Message-ID: <MN2PR11MB404540A828EDDE82F00E8E2BEA1A9@MN2PR11MB4045.namprd11.prod.outlook.com>
Date:   Wed, 7 Dec 2022 14:56:30 +0000
From:   "Rout, ChandanX" <chandanx.rout@...el.com>
To:     "Lobakin, Alexandr" <alexandr.lobakin@...el.com>,
        Leon Romanovsky <leon@...nel.org>,
        "Fijalkowski, Maciej" <maciej.fijalkowski@...el.com>
CC:     "Sarkar, Tirthendu" <tirthendu.sarkar@...el.com>,
        "tirtha@...il.com" <tirtha@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Karlsson, Magnus" <magnus.karlsson@...el.com>,
        "Kuruvinakunnel, George" <george.kuruvinakunnel@...el.com>,
        "Nagaraju, Shwetha" <shwetha.nagaraju@...el.com>,
        "Nagraj, Shravan" <shravan.nagraj@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH intel-next v4] i40e: allow toggling
 loopback mode via ndo_set_features callback

Hi Team,
We observed some different result on i40e driver which are as follows 

Issue Summary: Unable to find loopback test in "ethtool -t <interface> using i40e driver using latest next-queue.
Observations:
===========
1. we are able to enable loopback mode on i40e driver.
2. We are unable to find loopback test in "ethtool -t <interface>" command while using i40e driver.
3. However, in ice driver we are able to enable loopback mode also we are able to see the loopback test using "ethtool -t <interface>".

Note: Detail Observation is attached in excel format.

On I40e
=======
[root@...alhost admin]# ethtool -k ens802f3 | grep loopback
loopback: off
[root@...alhost admin]# ethtool -K ens802f3 loopback on
[root@...alhost admin]# ethtool -k ens802f3 | grep loopback
loopback: on
[root@...alhost admin]# ethtool -t ens802f3 online
The test result is PASS
The test extra info:
Register test  (offline)         0
Eeprom test    (offline)         0
Interrupt test (offline)         0
Link test   (on/offline)         0
[root@...alhost admin]# ethtool -t ens802f3 offline
The test result is PASS
The test extra info:
Register test  (offline)         0
Eeprom test    (offline)         0
Interrupt test (offline)         0
Link test   (on/offline)         0

On ice
=====
[root@...alhost admin]# ethtool -k ens801f0np0 | grep loopback
loopback: off
[root@...alhost admin]# ethtool -K ens801f0np0 loopback on
[root@...alhost admin]# ethtool -k ens801f0np0 | grep loopback
loopback: on
[root@...alhost admin]# ethtool -t ens801f0np0 online
The test result is PASS
The test extra info:
Register test  (offline)         0
EEPROM test    (offline)         0
Interrupt test (offline)         0
Loopback test  (offline)         0
Link test   (on/offline)         0
[root@...alhost admin]# ethtool -t ens801f0np0 offline
The test result is PASS
The test extra info:
Register test  (offline)         0
EEPROM test    (offline)         0
Interrupt test (offline)         0
Loopback test  (offline)         0
Link test   (on/offline)         0

Thanks & Regards
Chandan Kumar Rout

-----Original Message-----
From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Lobakin, Alexandr
Sent: 22 November 2022 21:28
To: Leon Romanovsky <leon@...nel.org>
Cc: Sarkar, Tirthendu <tirthendu.sarkar@...el.com>; tirtha@...il.com; intel-wired-lan@...ts.osuosl.org; netdev@...r.kernel.org; Karlsson, Magnus <magnus.karlsson@...el.com>
Subject: Re: [Intel-wired-lan] [PATCH intel-next v4] i40e: allow toggling loopback mode via ndo_set_features callback

From: Leon Romanovsky <leon@...nel.org>
Date: Tue, 22 Nov 2022 13:07:28 +0200

> On Fri, Nov 18, 2022 at 02:33:06PM +0530, Tirthendu Sarkar wrote:
> > Add support for NETIF_F_LOOPBACK. This feature can be set via:
> > $ ethtool -K eth0 loopback <on|off>
> > 
> > This sets the MAC Tx->Rx loopback.
> > 
> > This feature is used for the xsk selftests, and might have other 
> > uses too.

[...]

> > @@ -12960,6 +12983,9 @@ static int i40e_set_features(struct net_device *netdev,
> >  	if (need_reset)
> >  		i40e_do_reset(pf, I40E_PF_RESET_FLAG, true);
> >  
> > +	if ((features ^ netdev->features) & NETIF_F_LOOPBACK)
> > +		return i40e_set_loopback(vsi, !!(features & NETIF_F_LOOPBACK));
> 
> Don't you need to disable loopback if NETIF_F_LOOPBACK was cleared?

0 ^ 1 == 1 -> call i40e_set_loopback()
!!(0) == 0 -> disable

> 
> > +
> >  	return 0;
> >  }
> >  
> > @@ -13722,7 +13748,7 @@ static int i40e_config_netdev(struct i40e_vsi *vsi)
> >  	if (!(pf->flags & I40E_FLAG_MFP_ENABLED))
> >  		hw_features |= NETIF_F_NTUPLE | NETIF_F_HW_TC;
> >  
> > -	netdev->hw_features |= hw_features;
> > +	netdev->hw_features |= hw_features | NETIF_F_LOOPBACK;
> >  

Reviewed-by: Alexander Lobakin <alexandr.lobakin@...el.com>

Thanks,
Olek
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@...osl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

Download attachment "Loopback_Patch.xlsx" of type "application/vnd.openxmlformats-officedocument.spreadsheetml.sheet" (92027 bytes)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives