netdev - Re: [PATCH v2 resend 1/4] net: emaclite: don't call dev_kfree_skb() under spin_lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFcVECLB_4mCyzaDUrxLWHSjnKZZmfSJevUVptqcY+GMYCh7xw@mail.gmail.com>
Date:   Thu, 8 Dec 2022 14:55:00 +0530
From:   Harini Katakam <harinikatakamlinux@...il.com>
To:     Yang Yingliang <yangyingliang@...wei.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com,
        Michal Simek <michal.simek@...inx.com>,
        John Linn <john.linn@...inx.com>,
        Sadanand M <sadanan@...inx.com>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 resend 1/4] net: emaclite: don't call dev_kfree_skb()
 under spin_lock_irqsave()

On Thu, Dec 8, 2022 at 9:04 AM Yang Yingliang <yangyingliang@...wei.com> wrote:
>
> It is not allowed to call consume_skb() from hardware interrupt context
> or with interrupts being disabled. So replace dev_kfree_skb() with
> dev_consume_skb_irq() under spin_lock_irqsave().
>
> Fixes: bb81b2ddfa19 ("net: add Xilinx emac lite device driver")
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>

Thanks for the patch Yang
Reviewed-by: Harini Katakam <harini.katakam@....com>

Regards,
Harini