netdev - Re: [PATCH v2 resend 0/4] net: don't call dev_kfree_skb() under spin_lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 8 Dec 2022 11:29:04 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     Yang Yingliang <yangyingliang@...wei.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com,
        Michal Simek <michal.simek@...inx.com>,
        John Linn <john.linn@...inx.com>,
        Sadanand M <sadanan@...inx.com>,
        linux-arm-kernel@...ts.infradead.org,
        Ilya Yanok <yanok@...raft.com>,
        Joerg Reuter <jreuter@...na.de>, linux-hams@...r.kernel.org
Subject: Re: [PATCH v2 resend 0/4] net: don't call dev_kfree_skb() under
 spin_lock_irqsave()

On Thu, Dec 08, 2022 at 11:26:51AM +0800, Yang Yingliang wrote:
> It is not allowed to call consume_skb() from hardware interrupt context
> or with interrupts being disabled. This patchset replace dev_kfree_skb()
> with dev_consume_skb_irq() under spin_lock_irqsave() in some drivers, or
> move dev_kfree_skb() after spin_unlock_irqrestore().

Like I said it to you already. You MUST explain why dev_consume_skb_irq()
was chosen over dev_kfree_skb_irq().

Thanks

> 
> Resend for CC all authors / reviewers of commits under "Fixes:".
> 
> v1 -> v2:
>   patch #2 Move dev_kfree_skb() after spin_unlock_irqrestore()
> 
> Yang Yingliang (4):
>   net: emaclite: don't call dev_kfree_skb() under spin_lock_irqsave()
>   net: ethernet: dnet: don't call dev_kfree_skb() under
>     spin_lock_irqsave()
>   hamradio: don't call dev_kfree_skb() under spin_lock_irqsave()
>   net: amd: lance: don't call dev_kfree_skb() under spin_lock_irqsave()
> 
>  drivers/net/ethernet/amd/atarilance.c         | 2 +-
>  drivers/net/ethernet/amd/lance.c              | 2 +-
>  drivers/net/ethernet/dnet.c                   | 4 ++--
>  drivers/net/ethernet/xilinx/xilinx_emaclite.c | 2 +-
>  drivers/net/hamradio/scc.c                    | 6 +++---
>  5 files changed, 8 insertions(+), 8 deletions(-)
> 
> -- 
> 2.25.1
>