netdev - Re: [PATCH net-next v2 12/15] ice: handle flushing stale Tx timestamps in ice_ptp_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2ae326bd-a8a0-ce88-606d-32da3dc96597@intel.com>
Date:   Wed, 7 Dec 2022 17:12:18 -0800
From:   Jacob Keller <jacob.e.keller@...el.com>
To:     Saeed Mahameed <saeed@...nel.org>
CC:     <davem@...emloft.net>, <kuba@...nel.org>, <pabeni@...hat.com>,
        <edumazet@...gle.com>, <netdev@...r.kernel.org>,
        <richardcochran@...il.com>, <leon@...nel.org>,
        Gurucharan G <gurucharanx.g@...el.com>
Subject: Re: [PATCH net-next v2 12/15] ice: handle flushing stale Tx
 timestamps in ice_ptp_tx_tstamp



On 12/7/2022 3:56 PM, Saeed Mahameed wrote:
> On 07 Dec 13:09, Tony Nguyen wrote:
>> From: Jacob Keller <jacob.e.keller@...el.com>
>>
>> In the event of a PTP clock time change due to .adjtime or .settime, the
>> ice driver needs to update the cached copy of the PHC time and also 
>> discard
>> any outstanding Tx timestamps.
>>
> 
> [...]
> 
>> +static void
>> +ice_ptp_mark_tx_tracker_stale(struct ice_ptp_tx *tx)
>> +{
>> +    u8 idx;
>> +
>> +    spin_lock(&tx->lock);
>> +    for_each_set_bit(idx, tx->in_use, tx->len)
>> +        set_bit(idx, tx->stale);
> 
> nit: bitmap_or()?
> 

Ah good point, yea we could just use bitmap_or instead of 
for_each_set_bit here.