netdev - Re: [PATCH net-next v2 10/15] ice: disable Tx timestamps while link is down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c76fdcf2-29e8-c8a1-2c31-b33bbb88d625@intel.com>
Date:   Wed, 7 Dec 2022 17:15:41 -0800
From:   Jacob Keller <jacob.e.keller@...el.com>
To:     Saeed Mahameed <saeed@...nel.org>,
        Tony Nguyen <anthony.l.nguyen@...el.com>
CC:     <davem@...emloft.net>, <kuba@...nel.org>, <pabeni@...hat.com>,
        <edumazet@...gle.com>, <netdev@...r.kernel.org>,
        <richardcochran@...il.com>, <leon@...nel.org>,
        Gurucharan G <gurucharanx.g@...el.com>
Subject: Re: [PATCH net-next v2 10/15] ice: disable Tx timestamps while link
 is down



On 12/7/2022 3:46 PM, Saeed Mahameed wrote:
> On 07 Dec 13:09, Tony Nguyen wrote:
>> From: Jacob Keller <jacob.e.keller@...el.com>
>>
>> Introduce a new link_down field for the Tx tracker which indicates 
>> whether
>> the link is down for a given port.
>>
>> Use this bit to prevent any Tx timestamp requests from starting while 
>> link
> Can tx timestamp requests be generated in a context other than the xmit ndo
> ? how ?
> 

As far as I know, there is no other way. Only the xmit ndo routine.

> why not just use the same sync mechanisms we have for tx queues, 
> carrier_down etc ..?
> Anyway I'm just curious..

Hmm. That's a good point... I'm not sure what caused the case where we 
began a transmit request while the link was down...

I'll have to check into that.