netdev - Re: [PATCH net-next 01/14] bridge: mcast: Do not derive entry type from its filter mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6f71f4e4-9224-efa0-dbe2-e1b35b5526e2@blackwall.org>
Date:   Fri, 9 Dec 2022 09:27:01 +0200
From:   Nikolay Aleksandrov <razor@...ckwall.org>
To:     Ido Schimmel <idosch@...dia.com>, netdev@...r.kernel.org,
        bridge@...ts.linux-foundation.org
Cc:     davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
        edumazet@...gle.com, roopa@...dia.com, mlxsw@...dia.com
Subject: Re: [PATCH net-next 01/14] bridge: mcast: Do not derive entry type
 from its filter mode

On 08/12/2022 17:28, Ido Schimmel wrote:
> Currently, the filter mode (i.e., INCLUDE / EXCLUDE) of MDB entries
> cannot be set from user space. Instead, it is set by the kernel
> according to the entry type: (*, G) entries are treated as EXCLUDE and
> (S, G) entries are treated as INCLUDE. This allows the kernel to derive
> the entry type from its filter mode.
> 
> Subsequent patches will allow user space to set the filter mode of (*,
> G) entries, making the current assumption incorrect.
> 
> As a preparation, remove the current assumption and instead determine
> the entry type from its key, which is a more direct way.
> 
> Signed-off-by: Ido Schimmel <idosch@...dia.com>
> ---
>  net/bridge/br_mdb.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/net/bridge/br_mdb.c b/net/bridge/br_mdb.c
> index ae7d93c08880..2b6921dbdc02 100644
> --- a/net/bridge/br_mdb.c
> +++ b/net/bridge/br_mdb.c
> @@ -857,17 +857,14 @@ static int br_mdb_add_group(const struct br_mdb_config *cfg,
>  	 * added to it for proper replication
>  	 */
>  	if (br_multicast_should_handle_mode(brmctx, group.proto)) {
> -		switch (filter_mode) {
> -		case MCAST_EXCLUDE:
> -			br_multicast_star_g_handle_mode(p, MCAST_EXCLUDE);
> -			break;
> -		case MCAST_INCLUDE:
> +		if (br_multicast_is_star_g(&group)) {
> +			br_multicast_star_g_handle_mode(p, filter_mode);
> +		} else {
>  			star_group = p->key.addr;
>  			memset(&star_group.src, 0, sizeof(star_group.src));
>  			star_mp = br_mdb_ip_get(br, &star_group);
>  			if (star_mp)
>  				br_multicast_sg_add_exclude_ports(star_mp, p);
> -			break;
>  		}
>  	}
>  

Acked-by: Nikolay Aleksandrov <razor@...ckwall.org>