netdev - Re: [PATCH net-next 02/14] bridge: mcast: Split (*, G) and (S, G) addition into different functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9246d282-2691-d1c4-c1cc-fe3f0461e330@blackwall.org>
Date:   Fri, 9 Dec 2022 09:29:53 +0200
From:   Nikolay Aleksandrov <razor@...ckwall.org>
To:     Ido Schimmel <idosch@...dia.com>, netdev@...r.kernel.org,
        bridge@...ts.linux-foundation.org
Cc:     davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
        edumazet@...gle.com, roopa@...dia.com, mlxsw@...dia.com
Subject: Re: [PATCH net-next 02/14] bridge: mcast: Split (*, G) and (S, G)
 addition into different functions

On 08/12/2022 17:28, Ido Schimmel wrote:
> When the bridge is using IGMP version 3 or MLD version 2, it handles the
> addition of (*, G) and (S, G) entries differently.
> 
> When a new (S, G) port group entry is added, all the (*, G) EXCLUDE
> ports need to be added to the port group of the new entry. Similarly,
> when a new (*, G) EXCLUDE port group entry is added, the port needs to
> be added to the port group of all the matching (S, G) entries.
> 
> Subsequent patches will create more differences between both entry
> types. Namely, filter mode and source list can only be specified for (*,
> G) entries.
> 
> Given the current and future differences between both entry types,
> handle the addition of each entry type in a different function, thereby
> avoiding the creation of one complex function.
> 
> Signed-off-by: Ido Schimmel <idosch@...dia.com>
> ---
>  net/bridge/br_mdb.c | 145 +++++++++++++++++++++++++++++---------------
>  1 file changed, 96 insertions(+), 49 deletions(-)
> 

Acked-by: Nikolay Aleksandrov <razor@...ckwall.org>