netdev - Re: [PATCH net-next 04/14] bridge: mcast: Add a centralized error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2fa88776-fc7e-564c-18d9-83c75414b838@blackwall.org>
Date:   Fri, 9 Dec 2022 09:30:21 +0200
From:   Nikolay Aleksandrov <razor@...ckwall.org>
To:     Ido Schimmel <idosch@...dia.com>, netdev@...r.kernel.org,
        bridge@...ts.linux-foundation.org
Cc:     davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
        edumazet@...gle.com, roopa@...dia.com, mlxsw@...dia.com
Subject: Re: [PATCH net-next 04/14] bridge: mcast: Add a centralized error
 path

On 08/12/2022 17:28, Ido Schimmel wrote:
> Subsequent patches will add memory allocations in br_mdb_config_init()
> as the MDB configuration structure will include a linked list of source
> entries. This memory will need to be freed regardless if br_mdb_add()
> succeeded or failed.
> 
> As a preparation for this change, add a centralized error path where the
> memory will be freed.
> 
> Note that br_mdb_del() already has one error path and therefore does not
> require any changes.
> 
> Signed-off-by: Ido Schimmel <idosch@...dia.com>
> ---
>  net/bridge/br_mdb.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 

Acked-by: Nikolay Aleksandrov <razor@...ckwall.org>