netdev - Re: [PATCH net-next 05/14] bridge: mcast: Expose br_multicast_new_group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <455ce972-3b48-4ec3-92c8-3a50f7d96918@blackwall.org>
Date:   Fri, 9 Dec 2022 09:30:45 +0200
From:   Nikolay Aleksandrov <razor@...ckwall.org>
To:     Ido Schimmel <idosch@...dia.com>, netdev@...r.kernel.org,
        bridge@...ts.linux-foundation.org
Cc:     davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
        edumazet@...gle.com, roopa@...dia.com, mlxsw@...dia.com
Subject: Re: [PATCH net-next 05/14] bridge: mcast: Expose
 br_multicast_new_group_src()

On 08/12/2022 17:28, Ido Schimmel wrote:
> Currently, new group source entries are only created in response to
> received Membership Reports. Subsequent patches are going to allow user
> space to install (*, G) entries with a source list.
> 
> As a preparatory step, expose br_multicast_new_group_src() so that it
> could later be invoked from the MDB code (i.e., br_mdb.c) that handles
> RTM_NEWMDB messages.
> 
> Signed-off-by: Ido Schimmel <idosch@...dia.com>
> ---
>  net/bridge/br_multicast.c | 2 +-
>  net/bridge/br_private.h   | 3 +++
>  2 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
> index db4c3900ae95..b2bc23fdcee5 100644
> --- a/net/bridge/br_multicast.c
> +++ b/net/bridge/br_multicast.c
> @@ -1232,7 +1232,7 @@ br_multicast_find_group_src(struct net_bridge_port_group *pg, struct br_ip *ip)
>  	return NULL;
>  }
>  
> -static struct net_bridge_group_src *
> +struct net_bridge_group_src *
>  br_multicast_new_group_src(struct net_bridge_port_group *pg, struct br_ip *src_ip)
>  {
>  	struct net_bridge_group_src *grp_src;
> diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h
> index 3997e16c15fc..183de6c57d72 100644
> --- a/net/bridge/br_private.h
> +++ b/net/bridge/br_private.h
> @@ -974,6 +974,9 @@ void br_multicast_sg_add_exclude_ports(struct net_bridge_mdb_entry *star_mp,
>  				       struct net_bridge_port_group *sg);
>  struct net_bridge_group_src *
>  br_multicast_find_group_src(struct net_bridge_port_group *pg, struct br_ip *ip);
> +struct net_bridge_group_src *
> +br_multicast_new_group_src(struct net_bridge_port_group *pg,
> +			   struct br_ip *src_ip);
>  void br_multicast_del_group_src(struct net_bridge_group_src *src,
>  				bool fastleave);
>  void br_multicast_ctx_init(struct net_bridge *br,

Acked-by: Nikolay Aleksandrov <razor@...ckwall.org>