netdev - Re: [PATCH net-next] net: microchip: vcap: Fix initialization of value and mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y5PCmYVzx3nuZ9qa@x130>
Date:   Fri, 9 Dec 2022 15:19:53 -0800
From:   Saeed Mahameed <saeed@...nel.org>
To:     Horatiu Vultur <horatiu.vultur@...rochip.com>
Cc:     linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        Steen.Hegelund@...rochip.com, daniel.machon@...rochip.com,
        lars.povlsen@...rochip.com, UNGLinuxDriver@...rochip.com,
        kernel test robot <lkp@...el.com>,
        Dan Carpenter <error27@...il.com>
Subject: Re: [PATCH net-next] net: microchip: vcap: Fix initialization of
 value and mask

On 09 Dec 13:07, Horatiu Vultur wrote:
>Fix the following smatch warning:
>
>smatch warnings:
>drivers/net/ethernet/microchip/vcap/vcap_api_debugfs.c:103 vcap_debugfs_show_rule_keyfield() error: uninitialized symbol 'value'.
>drivers/net/ethernet/microchip/vcap/vcap_api_debugfs.c:106 vcap_debugfs_show_rule_keyfield() error: uninitialized symbol 'mask'.
>
>In case the vcap field was VCAP_FIELD_U128 and the key was different
>than IP6_S/DIP then the value and mask were not initialized, therefore
>initialize them.
>
>Fixes: 610c32b2ce66 ("net: microchip: vcap: Add vcap_get_rule")
>Reported-by: kernel test robot <lkp@...el.com>
>Reported-by: Dan Carpenter <error27@...il.com>
>Signed-off-by: Horatiu Vultur <horatiu.vultur@...rochip.com>

Reviewed-by: Saeed Mahameed <saeed@...nel.org>