[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 12 Dec 2022 13:02:24 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Horatiu Vultur <horatiu.vultur@...rochip.com>
Cc: <linux-arm-kernel@...ts.infradead.org>, <netdev@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <davem@...emloft.net>,
<edumazet@...gle.com>, <pabeni@...hat.com>,
<Steen.Hegelund@...rochip.com>, <daniel.machon@...rochip.com>,
<lars.povlsen@...rochip.com>, <UNGLinuxDriver@...rochip.com>,
kernel test robot <lkp@...el.com>,
"Dan Carpenter" <error27@...il.com>
Subject: Re: [PATCH net-next] net: microchip: vcap: Fix initialization of
value and mask
On Fri, 9 Dec 2022 13:07:01 +0100 Horatiu Vultur wrote:
> case VCAP_FIELD_U128:
> + value = data->u128.value;
> + mask = data->u128.value;
If setting both to value is intentional - please mention in the commit
message. Otherwise this looks odd.
Powered by blists - more mailing lists