netdev - Re: [net-next 14/15] net/mlx5: SRIOV, Add 802.1ad VST support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221208170459.538917da@kernel.org>
Date:   Thu, 8 Dec 2022 17:04:59 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Saeed Mahameed <saeedm@...dia.com>
Cc:     Saeed Mahameed <saeed@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>, netdev@...r.kernel.org,
        Tariq Toukan <tariqt@...dia.com>,
        Moshe Shemesh <moshe@...dia.com>,
        Mark Bloch <mbloch@...dia.com>
Subject: Re: [net-next 14/15] net/mlx5: SRIOV, Add 802.1ad VST support

On Thu, 8 Dec 2022 00:28:38 -0800 Saeed Mahameed wrote:
> So if the part in this series of adding support for 802.1ad, falls under that
> policy, then i must agree with you. I will drop it.

Part of me was hoping there's a silver bullet or a compromise,
and I was not seeing it.. :)

> But another part in this series is fixing a critical bug were we drop VF tagged
> packets when vst in ON, we will strip that part out and send it as a
> bug fix, it is really critical, mlx5 vst basically doesn't work upstream for
> tagged traffic.

What's the setup in that case?  My immediate thought is why would 
VST be on if it's only needed for .1ad and that's not used?