netdev - Re: [net-next 14/15] net/mlx5: SRIOV, Add 802.1ad VST support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y5KWJYBij3bzg5hU@x130>
Date:   Thu, 8 Dec 2022 17:57:57 -0800
From:   Saeed Mahameed <saeed@...nel.org>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Saeed Mahameed <saeedm@...dia.com>,
        "David S. Miller" <davem@...emloft.net>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>, netdev@...r.kernel.org,
        Tariq Toukan <tariqt@...dia.com>,
        Moshe Shemesh <moshe@...dia.com>,
        Mark Bloch <mbloch@...dia.com>
Subject: Re: [net-next 14/15] net/mlx5: SRIOV, Add 802.1ad VST support

On 08 Dec 17:04, Jakub Kicinski wrote:
>On Thu, 8 Dec 2022 00:28:38 -0800 Saeed Mahameed wrote:
>> So if the part in this series of adding support for 802.1ad, falls under that
>> policy, then i must agree with you. I will drop it.
>
>Part of me was hoping there's a silver bullet or a compromise,
>and I was not seeing it.. :)
>
>> But another part in this series is fixing a critical bug were we drop VF tagged
>> packets when vst in ON, we will strip that part out and send it as a
>> bug fix, it is really critical, mlx5 vst basically doesn't work upstream for
>> tagged traffic.
>
>What's the setup in that case?  My immediate thought is why would
>VST be on if it's only needed for .1ad and that's not used?

So the whole thing started from finding these gaps in our out of tree 
driver. there's the bug fix i will explain below, and the addition of .1ad
both were found missing upstream when we convinced a customer to switch
to upstream/inbox driver.

vst .1q and vst .1ad are both totally separate scenarios and use cases for
the customers.

Currently upstream mlx5 only support VST for vlan proto .1q, 
but it's buggy when traffic from the guest comes with a vlan tag, 
depending on the HW/FW version, either the packets get dropped or
the guest vlans get overridden with the VST host vlan, this is due to
wrong interpretation of the hw steering rules in the initial driver
implementation. in both cases it's a bug and the latter is even worse.