netdev - Re: [PATCH net-next v6] virtio/vsock: replace virtio_vsock_pkt with sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y34SoH1nFTXXLWbK@bullseye>
Date:   Wed, 23 Nov 2022 12:31:28 +0000
From:   Bobby Eshleman <bobbyeshleman@...il.com>
To:     Stefano Garzarella <sgarzare@...hat.com>
Cc:     "Michael S. Tsirkin" <mst@...hat.com>,
        Bobby Eshleman <bobby.eshleman@...edance.com>,
        Cong Wang <cong.wang@...edance.com>,
        Krasnov Arseniy <oxffffaa@...il.com>,
        Jiang Wang <jiang.wang@...edance.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        virtualization@...ts.linux-foundation.org,
        Eric Dumazet <edumazet@...gle.com>,
        Stefan Hajnoczi <stefanha@...hat.com>, kvm@...r.kernel.org,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH net-next v6] virtio/vsock: replace virtio_vsock_pkt with
 sk_buff

On Tue, Dec 13, 2022 at 04:43:04PM +0100, Stefano Garzarella wrote:
> On Tue, Dec 13, 2022 at 10:06:23AM -0500, Michael S. Tsirkin wrote:
> > On Tue, Dec 13, 2022 at 11:22:32AM +0100, Stefano Garzarella wrote:
> > > > +	if (len <= GOOD_COPY_LEN && !skb_queue_empty_lockless(&vvs->rx_queue)) {
> > > 
> > > Same here.
> > > 
> > > If there are no major changes to be made, I think the next version is the
> > > final ones, though we are now in the merge window, so net-next is closed
> > > [1], only RFCs can be sent [2].
> > > 
> > > I suggest you wait until the merge window is over (two weeks usually) to
> > > send the next version.
> > 
> > Nah, you never know, could be more comments. And depending on the timing
> > I might be able to merge it.
> 
> Right, in the end these changes are only to virtio-vsock transport, so they
> can go smoothly even with your tree.
> 
> @Bobby, so if you can fix the remaining small things, we can try to merge it
> :-)
> 
> Thanks,
> Stefano

Sure thing. I'll change / send now.

Best,
Bobby