netdev - Re: [PATCH v3] epoll: use refcount to reduce ep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 13 Dec 2022 19:21:14 +0100
From:   Paolo Abeni <pabeni@...hat.com>
To:     Eric Biggers <ebiggers@...nel.org>
Cc:     linux-fsdevel@...r.kernel.org,
        Soheil Hassas Yeganeh <soheil@...gle.com>,
        Al Viro <viro@...iv.linux.org.uk>,
        Davidlohr Bueso <dave@...olabs.net>,
        Jason Baron <jbaron@...mai.com>, netdev@...r.kernel.org,
        Carlos Maiolino <cmaiolino@...hat.com>
Subject: Re: [PATCH v3] epoll: use refcount to reduce ep_mutex contention

Hi,

On Mon, 2022-12-12 at 22:01 -0800, Eric Biggers wrote:
> I am trying to understand whether this patch is correct.
> 
> One thing that would help would be to use more standard naming:
> 
> 	ep_put => ep_refcount_dec_and_test (or ep_put_and_test)
> 	ep_dispose => ep_free
> 	ep_free => ep_clear_and_put

Thank you for the feedback. 

I must admit I'm not good at all at selecting good names, so I
definitelly will apply the above. I additionally still have to cover
the feedback from Jacob - switching the reference count to a kref - as
I've been diverted to other tasks.

I hope to be able to share a new revision of this patch next week.

Thanks,

Paolo