netdev - Re: [PATCH net] net: enetc: avoid buffer leaks on xdp_do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221214121725.g4ox7it4aeumde6x@skbuf>
Date:   Wed, 14 Dec 2022 14:17:25 +0200
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     netdev@...r.kernel.org
Cc:     "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Claudiu Manoil <claudiu.manoil@....com>,
        linux-kernel@...r.kernel.org,
        Lorenzo Bianconi <lorenzo.bianconi@...hat.com>
Subject: Re: [PATCH net] net: enetc: avoid buffer leaks on xdp_do_redirect()
 failure

On Tue, Dec 13, 2022 at 02:19:08AM +0200, Vladimir Oltean wrote:
> The problem, summarized, is that we zeroize rx_swbd->page before we're
> completely done with it, and this makes it impossible for the error path
> to do something with it.
> ---

I was pretty tired when I wrote this commit message, please let me know
if it rambles too much or it misses the point, I can rewrite it and
shorten it if needed.