netdev - Re: [PATCH net v2] net: atm: Fix use-after-free bug in atm_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y5ohNlJ4moB+wwdA@unreal>
Date:   Wed, 14 Dec 2022 21:17:10 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Nir Levy <bhr166@...il.com>, davem@...emloft.net,
        edumazet@...gle.com, pabeni@...hat.com,
        linux-atm-general@...ts.sourceforge.net, netdev@...r.kernel.org
Subject: Re: [PATCH net v2] net: atm: Fix use-after-free bug in
 atm_dev_register()

On Wed, Dec 14, 2022 at 08:43:58AM -0800, Jakub Kicinski wrote:
> On Wed, 14 Dec 2022 09:51:09 +0200 Leon Romanovsky wrote:
> > > Also atm_dev_register() still frees the dev on atm_register_sysfs()
> > > failure, is that okay?  
> > 
> > Yes, the kernel panic points that class_dev (not dev) had use-after-free.
> 
> How is that possible? "class_dev" is embedded in dev (struct atm_dev).

Right, the more I think about this call trace, the less I'm sure.

Thanks