netdev - Re: [PATCH v1 net] af_unix: Add error handling in af_unix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 14 Dec 2022 11:18:05 -0800
From:   Alexander H Duyck <alexander.duyck@...il.com>
To:     Kuniyuki Iwashima <kuniyu@...zon.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
Cc:     "Denis V. Lunev" <den@...nvz.org>,
        Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v1 net] af_unix: Add error handling in af_unix_init().

On Wed, 2022-12-14 at 18:20 +0900, Kuniyuki Iwashima wrote:
> sock_register() and register_pernet_subsys() in af_unix_init() could
> fail.
> 
> For example, after loading another PF_UNIX module (it's improbable
> though), loading unix.ko fails at sock_register() and leaks slab
> memory.  Also, register_pernet_subsys() fails when running out of
> memory.
> 
> Let's handle errors appropriately.
> 
> Fixes: 097e66c57845 ("[NET]: Make AF_UNIX per network namespace safe [v2]")
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...zon.com>

So the "Fixes" tags for this are no good. The 2nd one is from the start
of using git for the kernel. As such I am suspecting that this isn't
fixing a patch that introduced an issue.

Since it doesn't really seem like this is fixing an issue other than
adding some additional exception handling. I would suggest getting rid
of the "Fixes" tags and just submitting this for net-next once the
window opens.

The code itself looks fine, but I don't think it is really fixing much
either. If you want to wait to submit this for net-next you can include
this:

Reviewed-by: Alexander Duyck <alexanderduyck@...com>