netdev - Re: [PATCH net v2] net: atm: Fix use-after-free bug in atm_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221213191233.5d0a7c8f@kernel.org>
Date:   Tue, 13 Dec 2022 19:12:33 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Leon Romanovsky <leon@...nel.org>
Cc:     Nir Levy <bhr166@...il.com>, davem@...emloft.net,
        edumazet@...gle.com, pabeni@...hat.com,
        linux-atm-general@...ts.sourceforge.net, netdev@...r.kernel.org
Subject: Re: [PATCH net v2] net: atm: Fix use-after-free bug in
 atm_dev_register()

On Mon, 12 Dec 2022 09:12:30 +0200 Leon Romanovsky wrote:
> > v2: Call put_device in atm_register_sysfs instead of atm_dev_register.
> 
> Reviewed-by: Leon Romanovsky <leonro@...dia.com>

On one of the previous versions you commented that
atm_unregister_sysfs() also needs to move to unregister() rather 
than del():

https://lore.kernel.org/all/Y48CwyATYAAcPgqT@unreal/

Is that not the case?

Also atm_dev_register() still frees the dev on atm_register_sysfs()
failure, is that okay?