lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20221213191528.75cd2ff0@kernel.org> Date: Tue, 13 Dec 2022 19:15:28 -0800 From: Jakub Kicinski <kuba@...nel.org> To: Gaosheng Cui <cuigaosheng1@...wei.com> Cc: <peppe.cavallaro@...com>, <alexandre.torgue@...s.st.com>, <joabreu@...opsys.com>, <davem@...emloft.net>, <edumazet@...gle.com>, <pabeni@...hat.com>, <mcoquelin.stm32@...il.com>, <ast@...nel.org>, <daniel@...earbox.net>, <hawk@...nel.org>, <john.fastabend@...il.com>, <boon.leong.ong@...el.com>, <netdev@...r.kernel.org>, <linux-stm32@...md-mailman.stormreply.com>, <linux-arm-kernel@...ts.infradead.org> Subject: Re: [PATCH v2] net: stmmac: fix possible memory leak in stmmac_dvr_probe() On Mon, 12 Dec 2022 10:13:50 +0800 Gaosheng Cui wrote: > The bitmap_free() should be called to free priv->af_xdp_zc_qps > when create_singlethread_workqueue() fails, otherwise there will > be a memory leak, so we add the err path error_wq_init to fix it. > > Fixes: bba2556efad6 ("net: stmmac: Enable RX via AF_XDP zero-copy") > Signed-off-by: Gaosheng Cui <cuigaosheng1@...wei.com> The previous version has already been applied and we can't remove it. Could you send an incremental change to just add the errno?
Powered by blists - more mailing lists