lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <3142B112-D79A-48D2-970A-6B2DF45ACD30@redhat.com> Date: Thu, 15 Dec 2022 15:36:30 +0100 From: Eelco Chaudron <echaudro@...hat.com> To: Ilya Maximets <i.maximets@....org> Cc: netdev@...r.kernel.org, pshelar@....org, davem@...emloft.net, dev@...nvswitch.org, aconole@...hat.com, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com Subject: Re: [PATCH net v2] openvswitch: Fix flow lookup to use unmasked key On 15 Dec 2022, at 12:45, Ilya Maximets wrote: > On 12/14/22 17:33, Eelco Chaudron wrote: >> The commit mentioned below causes the ovs_flow_tbl_lookup() function >> to be called with the masked key. However, it's supposed to be called >> with the unmasked key. > > Hi, Eelco. Thanks for the fix! > > Could you, please, add more information to the commit message on > why this is a problem, with some examples? This will be useful > for someone in the future trying to understand why we actually > have to use an unmasked key here. ACK will add the same description as in the OVS dpif-netdev commit. > Also, I suppose, 'Cc: stable@...r.kernel.org' tag is needed in the > commit message since it's a fix for a bug that is actually impacts > users and needs to be backported. Will do in the v3. > Best regards, Ilya Maximets. > >> >> This change reverses the commit below, but rather than having the key >> on the stack, it's allocated. >> >> Fixes: 190aa3e77880 ("openvswitch: Fix Frame-size larger than 1024 bytes warning.") >> >> Signed-off-by: Eelco Chaudron <echaudro@...hat.com> >> >> --- >> Version history: >> - v2: Fixed ENOME(N/M) error. Forgot to do a stg refresh. >> >> net/openvswitch/datapath.c | 25 ++++++++++++++++--------- >> 1 file changed, 16 insertions(+), 9 deletions(-)
Powered by blists - more mailing lists