lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 15 Dec 2022 12:45:52 +0100
From:   Ilya Maximets <>
To:     Eelco Chaudron <>,
Subject: Re: [PATCH net v2] openvswitch: Fix flow lookup to use unmasked key

On 12/14/22 17:33, Eelco Chaudron wrote:
> The commit mentioned below causes the ovs_flow_tbl_lookup() function
> to be called with the masked key. However, it's supposed to be called
> with the unmasked key.

Hi, Eelco.  Thanks for the fix!

Could you, please, add more information to the commit message on
why this is a problem, with some examples?  This will be useful
for someone in the future trying to understand why we actually
have to use an unmasked key here.

Also, I suppose, 'Cc:' tag is needed in the
commit message since it's a fix for a bug that is actually impacts
users and needs to be backported.

Best regards, Ilya Maximets.

> This change reverses the commit below, but rather than having the key
> on the stack, it's allocated.
> Fixes: 190aa3e77880 ("openvswitch: Fix Frame-size larger than 1024 bytes warning.")
> Signed-off-by: Eelco Chaudron <>
> ---
> Version history:
>  - v2: Fixed ENOME(N/M) error. Forgot to do a stg refresh.
>  net/openvswitch/datapath.c |   25 ++++++++++++++++---------
>  1 file changed, 16 insertions(+), 9 deletions(-)

Powered by blists - more mailing lists