netdev - Re: [RFC net-next 06/15] devlink: use an explicit structure for dump context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0f79a6ea-13cd-98d7-1f88-c4e6375ade3a@intel.com>
Date:   Thu, 15 Dec 2022 10:50:11 -0800
From:   Jacob Keller <jacob.e.keller@...el.com>
To:     Jakub Kicinski <kuba@...nel.org>, <davem@...emloft.net>
CC:     <netdev@...r.kernel.org>, <edumazet@...gle.com>,
        <pabeni@...hat.com>, <jiri@...nulli.us>, <leon@...nel.org>
Subject: Re: [RFC net-next 06/15] devlink: use an explicit structure for dump
 context



On 12/14/2022 6:01 PM, Jakub Kicinski wrote:
> Create a dump context structure instead of using cb->args
> as an unsigned long array. This is a pure conversion which
> is intended to be as much of a noop as possible.
> Subsequent changes will use this to simplify the code.
> 
> The two non-trivial parts are:
>   - devlink_nl_cmd_health_reporter_dump_get_dumpit() checks args[0]
>     to see if devlink_fmsg_dumpit() has already been called (whether
>     this is the first msg), but doesn't use the exact value, so we
>     can drop the local variable there already
>   - devlink_nl_cmd_region_read_dumpit() uses args[0] for address
>     but we'll use args[1] now, shouldn't matter
> 

And to be clear, the context is not ABI since its not exported outside 
the kernel. Thus, these changes don't break compatibility with user space.