lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 15 Dec 2022 10:50:11 -0800
From:   Jacob Keller <>
To:     Jakub Kicinski <>, <>
CC:     <>, <>,
        <>, <>, <>
Subject: Re: [RFC net-next 06/15] devlink: use an explicit structure for dump

On 12/14/2022 6:01 PM, Jakub Kicinski wrote:
> Create a dump context structure instead of using cb->args
> as an unsigned long array. This is a pure conversion which
> is intended to be as much of a noop as possible.
> Subsequent changes will use this to simplify the code.
> The two non-trivial parts are:
>   - devlink_nl_cmd_health_reporter_dump_get_dumpit() checks args[0]
>     to see if devlink_fmsg_dumpit() has already been called (whether
>     this is the first msg), but doesn't use the exact value, so we
>     can drop the local variable there already
>   - devlink_nl_cmd_region_read_dumpit() uses args[0] for address
>     but we'll use args[1] now, shouldn't matter

And to be clear, the context is not ABI since its not exported outside 
the kernel. Thus, these changes don't break compatibility with user space.

Powered by blists - more mailing lists