netdev - Re: [RFC net-next 08/15] devlink: drop the filter argument from devlinks_xa_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <af89b94d-8cc0-17a7-2eea-ff0cb07bda19@intel.com>
Date:   Thu, 15 Dec 2022 10:52:31 -0800
From:   Jacob Keller <jacob.e.keller@...el.com>
To:     Jakub Kicinski <kuba@...nel.org>, <davem@...emloft.net>
CC:     <netdev@...r.kernel.org>, <edumazet@...gle.com>,
        <pabeni@...hat.com>, <jiri@...nulli.us>, <leon@...nel.org>
Subject: Re: [RFC net-next 08/15] devlink: drop the filter argument from
 devlinks_xa_find_get



On 12/14/2022 6:01 PM, Jakub Kicinski wrote:
> Looks like devlinks_xa_find_get() was intended to get the mark
> from the @filter argument. It doesn't actually use @filter, passing
> DEVLINK_REGISTERED to xa_find_fn() directly. Walking marks other
> than registered is unlikely so drop @filter argument completely.
> 

Yea, if somehow it ever becomes necessary we can add something back. 
There are a limited number of marks available anyways.

If it does become necessary we can always refactor this back at that point.

Thanks,
Jake