netdev - Re: [RFC net-next 10/15] devlink: restart dump based on devlink instance ids (simple)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <224645a4-990d-8c66-01e0-497a3f5f94af@intel.com>
Date:   Thu, 15 Dec 2022 10:59:07 -0800
From:   Jacob Keller <jacob.e.keller@...el.com>
To:     Jakub Kicinski <kuba@...nel.org>, <davem@...emloft.net>
CC:     <netdev@...r.kernel.org>, <edumazet@...gle.com>,
        <pabeni@...hat.com>, <jiri@...nulli.us>, <leon@...nel.org>
Subject: Re: [RFC net-next 10/15] devlink: restart dump based on devlink
 instance ids (simple)



On 12/14/2022 6:01 PM, Jakub Kicinski wrote:
> xarray gives each devlink instance an id and allows us to restart
> walk based on that id quite neatly. This is nice both from the
> perspective of code brevity and from the stability of the dump
> (devlink instances disappearing from before the resumption point
> will not cause inconsistent dumps).
> 
> This patch takes care of simple cases where dump->idx counts
> devlink instances only.


So with this change for now dump->instance and dump->idx will be 
identical, but we'll slowly change the meaning of dump->idx with each of 
the following changes as we expand the user of this macro.

Nice. Keeps it simpler to review. Thanks!