netdev - Re: [RFC net-next 14/15] devlink: add by-instance dump infra

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8d4304e8-f2a9-a107-26d1-d3aa4d7abf29@intel.com>
Date:   Thu, 15 Dec 2022 11:03:02 -0800
From:   Jacob Keller <jacob.e.keller@...el.com>
To:     Jakub Kicinski <kuba@...nel.org>, <davem@...emloft.net>
CC:     <netdev@...r.kernel.org>, <edumazet@...gle.com>,
        <pabeni@...hat.com>, <jiri@...nulli.us>, <leon@...nel.org>
Subject: Re: [RFC net-next 14/15] devlink: add by-instance dump infra



On 12/14/2022 6:01 PM, Jakub Kicinski wrote:
> Most dumpit implementations walk the devlink instances.
> This requires careful lock taking and reference dropping.
> Factor the loop out and provide just a callback to handle
> a single instance dump.
> 
> Convert one user as an example, other users converted
> in the next change.
> 
> Slightly inspired by ethtool netlink code.
> 

This is much nicer! A lot easier to read the dump for one instance than 
to try and parse out the iterating over each devlink.