netdev - Re: [RFC net-next 01/15] devlink: move code to a dedicated directory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221215110925.6a9d0f4a@kernel.org>
Date:   Thu, 15 Dec 2022 11:09:25 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
        pabeni@...hat.com, jacob.e.keller@...el.com, leon@...nel.org
Subject: Re: [RFC net-next 01/15] devlink: move code to a dedicated
 directory

On Thu, 15 Dec 2022 10:51:43 +0100 Jiri Pirko wrote:
> > net/Makefile                            | 1 +
> > net/core/Makefile                       | 1 -
> > net/devlink/Makefile                    | 3 +++
> > net/{core/devlink.c => devlink/basic.c} | 0  
> 
> What's "basic" about it? It sounds a bit misleading.

Agreed, but try to suggest a better name ;)  the_rest_of_it.c ? :)

> > 4 files changed, 4 insertions(+), 1 deletion(-)
> > create mode 100644 net/devlink/Makefile
> > rename net/{core/devlink.c => devlink/basic.c} (100%)
> >
> >diff --git a/net/Makefile b/net/Makefile
> >index 6a62e5b27378..0914bea9c335 100644
> >--- a/net/Makefile
> >+++ b/net/Makefile
> >@@ -23,6 +23,7 @@ obj-$(CONFIG_BPFILTER)		+= bpfilter/
> > obj-$(CONFIG_PACKET)		+= packet/
> > obj-$(CONFIG_NET_KEY)		+= key/
> > obj-$(CONFIG_BRIDGE)		+= bridge/
> >+obj-$(CONFIG_NET_DEVLINK)	+= devlink/  
> 
> Hmm, as devlink is not really designed to be only networking thing,
> perhaps this is good opportunity to move out of net/ and change the
> config name to "CONFIG_DEVLINK" ?

Nothing against it, but don't think it belongs in this patch.
So I call scope creep.