lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Sat, 17 Dec 2022 04:59:02 +0900
From:   Kang Minchul <>
To:     Alex Elder <>
Cc:     Alex Elder <>,
        "David S . Miller" <>,
        Jakub Kicinski <>,,
Subject: Re: [PATCH net-next v2] net: ipa: Remove redundant dev_err()

Thank you for your precious feedback.

> The current version of net-next/master, as well as the
> current linus/master, do not include the message you
> are removing.  This patch removed the message more than
> a year ago:
>    91306d1d131ee net: ipa: Remove useless error message
> So at least the portion of your patch that removes the
> message is unnecessary.

Yes, I think I mistakenly worked on the wrong branch..

> Meanwhile, it seems there is no need to check for a 0
> return from platform_get_irq_byname(), but there is
> no harm in doing so.
> If you would like to send version 3 of this patch, which
> would return what platform_get_irq_byname() returns if it
> is less than 0 in gsi_irq_init(), I would be OK with that.
> But please it on net-next/master.

Ok, I'll send v3 of this patch soon.

Powered by blists - more mailing lists