netdev - Re: [PATCH net-next v2] net: ipa: Remove redundant dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 12 Dec 2022 07:36:45 -0600
From:   Alex Elder <alex.elder@...aro.org>
To:     Kang Minchul <tegongkang@...il.com>, Alex Elder <elder@...nel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2] net: ipa: Remove redundant dev_err()

On 12/12/22 1:18 AM, Kang Minchul wrote:
> Function dev_err() is redundant because platform_get_irq_byname()
> already prints an error.
> 
> Also, platform_get_irq_byname() can't return 0 so ret <= 0
> should be ret < 0.
> 
> Signed-off-by: Kang Minchul <tegongkang@...il.com>

Now that I've looked at this closely, it's not clear what
version of the code you are basing your patch on.

The current version of net-next/master, as well as the
current linus/master, do not include the message you
are removing.  This patch removed the message more than
a year ago:

   91306d1d131ee net: ipa: Remove useless error message

So at least the portion of your patch that removes the
message is unnecessary.

Meanwhile, it seems there is no need to check for a 0
return from platform_get_irq_byname(), but there is
no harm in doing so.

If you would like to send version 3 of this patch, which
would return what platform_get_irq_byname() returns if it
is less than 0 in gsi_irq_init(), I would be OK with that.

But please it on net-next/master.

Thanks.

					-Alex

> ---
> Changes in v2:
>    - Annotate patch with net-next.
>    - Remove unnecessary comparison with zero.
> 
>   drivers/net/ipa/gsi.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ipa/gsi.c b/drivers/net/ipa/gsi.c
> index 55226b264e3c..a4f19f7f188e 100644
> --- a/drivers/net/ipa/gsi.c
> +++ b/drivers/net/ipa/gsi.c
> @@ -1967,11 +1967,8 @@ int gsi_init(struct gsi *gsi, struct platform_device *pdev, bool prefetch,
>   
>   	/* Get the GSI IRQ and request for it to wake the system */
>   	ret = platform_get_irq_byname(pdev, "gsi");
> -	if (ret <= 0) {
> -		dev_err(gsi->dev,
> -			"DT error %d getting \"gsi\" IRQ property\n", ret);
> +	if (ret < 0)
>   		return ret ? : -EINVAL;
> -	}
>   	irq = ret;
>   
>   	ret = request_irq(irq, gsi_isr, 0, "gsi", gsi);