netdev - AW: [PATCH v3 1/3] net: phy: add EXPORT_SYMBOL to phy_disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <GVXP190MB1917FAE75EC2A440A59922BCD9EA9@GVXP190MB1917.EURP190.PROD.OUTLOOK.COM>
Date:   Tue, 20 Dec 2022 16:47:07 +0000
From:   Sven Schuchmann <schuchmann@...leissheimer.de>
To:     Enguerrand de Ribaucourt 
        <enguerrand.de-ribaucourt@...oirfairelinux.com>,
        "Russell King (Oracle)" <linux@...linux.org.uk>
CC:     Heiner Kallweit <hkallweit1@...il.com>,
        netdev <netdev@...r.kernel.org>, Paolo Abeni <pabeni@...hat.com>,
        woojung huh <woojung.huh@...rochip.com>,
        davem <davem@...emloft.net>,
        UNGLinuxDriver <UNGLinuxDriver@...rochip.com>,
        Andrew Lunn <andrew@...n.ch>
Subject: AW: [PATCH v3 1/3] net: phy: add EXPORT_SYMBOL to
 phy_disable_interrupts()

> -----Ursprüngliche Nachricht-----
> Von: Enguerrand de Ribaucourt <enguerrand.de-ribaucourt@...oirfairelinux.com>
> Gesendet: Dienstag, 20. Dezember 2022 17:22
> An: Russell King (Oracle) <linux@...linux.org.uk>
> Cc: Heiner Kallweit <hkallweit1@...il.com>; netdev <netdev@...r.kernel.org>; Paolo Abeni
> <pabeni@...hat.com>; woojung huh <woojung.huh@...rochip.com>; davem <davem@...emloft.net>;
> UNGLinuxDriver <UNGLinuxDriver@...rochip.com>; Andrew Lunn <andrew@...n.ch>
> Betreff: Re: [PATCH v3 1/3] net: phy: add EXPORT_SYMBOL to phy_disable_interrupts()
> 
> In the meantime, I suggest removing the workaround from lan78xx.c since
> it is not compatible with most of the PHYs users of lan78xx.c could use.

Same over here, we are using the lan7801 together with a dp83tc811 from TI
and also had to remove this code. On the raspberrypi kernel there is also
this patch https://github.com/raspberrypi/linux/commit/2cc41cfc79323d90b7fd8f28b22e77db2a0c3360
which is also modifying LAN88XX registers from the lan78xx driver.
But I also have no idea how this could be fixed. 

Overall I would say to remove any PHY specific code from the LAN drivers
maybe by "fixup" function or something else. But at this time everyone
has to modify the lan78xx code, as the above patch indicates even 
you *are* using a LAN88XX Phy.

Maybe someone else as some ideas?

Sven