netdev - Re: [PATCH v3 1/3] net: phy: add EXPORT_SYMBOL to phy_disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y6Ho5rIlRHYPePEo@lunn.ch>
Date:   Tue, 20 Dec 2022 17:55:02 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Enguerrand de Ribaucourt 
        <enguerrand.de-ribaucourt@...oirfairelinux.com>
Cc:     Heiner Kallweit <hkallweit1@...il.com>,
        netdev <netdev@...r.kernel.org>, Paolo Abeni <pabeni@...hat.com>,
        woojung huh <woojung.huh@...rochip.com>,
        davem <davem@...emloft.net>,
        UNGLinuxDriver <UNGLinuxDriver@...rochip.com>,
        Russell King - ARM Linux <linux@...linux.org.uk>
Subject: Re: [PATCH v3 1/3] net: phy: add EXPORT_SYMBOL to
 phy_disable_interrupts()

On Tue, Dec 20, 2022 at 10:48:25AM -0500, Enguerrand de Ribaucourt wrote:
> > From: "Heiner Kallweit" <hkallweit1@...il.com>
> > To: "Enguerrand de Ribaucourt" <enguerrand.de-ribaucourt@...oirfairelinux.com>
> > Cc: "netdev" <netdev@...r.kernel.org>, "Paolo Abeni" <pabeni@...hat.com>, "woojung huh" <woojung.huh@...rochip.com>,
> > "davem" <davem@...emloft.net>, "UNGLinuxDriver" <UNGLinuxDriver@...rochip.com>, "Andrew Lunn" <andrew@...n.ch>,
> > "Russell King - ARM Linux" <linux@...linux.org.uk>
> > Sent: Tuesday, December 20, 2022 4:19:40 PM
> > Subject: Re: [PATCH v3 1/3] net: phy: add EXPORT_SYMBOL to phy_disable_interrupts()
> My proposed approach would be to copy the original workaround actions
> within link_change_notify():
>  1. disable interrupts
>  2. reset speed
>  3. enable interrupts
> 
> However, I don't have access to the LAN8835 to test if this would work. I also
> don't have knowledge about which other Microchip PHYs could be impacted. Maybe
> there is an active Microchip developer we could communicate with to find out?

Woojung Huh added this code, and he sometimes contributes here.

Woojung, do you still have access to the hardware?

	 Andrew