netdev - Re: [PATCH V2 net] net: fec: Coverity issue: Dereference null return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221220113610.77a11f25@kernel.org>
Date:   Tue, 20 Dec 2022 11:36:10 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     wei.fang@....com
Cc:     davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
        xiaoning.wang@....com, shenwei.wang@....com,
        alexander.duyck@...il.com, linux-imx@....com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 net] net: fec: Coverity issue: Dereference null
 return value

On Mon, 19 Dec 2022 10:27:55 +0800 wei.fang@....com wrote:
> From: Wei Fang <wei.fang@....com>
> 
> The build_skb might return a null pointer but there is no check on the
> return value in the fec_enet_rx_queue(). So a null pointer dereference
> might occur. To avoid this, we check the return value of build_skb. If
> the return value is a null pointer, the driver will recycle the page and
> update the statistic of ndev. Then jump to rx_processing_done to clear
> the status flags of the BD so that the hardware can recycle the BD.

Applied but I had to change the subject because the subject should
describe the change. Mentioning the tool which found the problem
belongs in the body of the message.