lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 21 Dec 2022 01:39:55 +0000 From: Wei Fang <wei.fang@....com> To: Jakub Kicinski <kuba@...nel.org> CC: "davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>, "pabeni@...hat.com" <pabeni@...hat.com>, Clark Wang <xiaoning.wang@....com>, Shenwei Wang <shenwei.wang@....com>, "alexander.duyck@...il.com" <alexander.duyck@...il.com>, dl-linux-imx <linux-imx@....com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: RE: [PATCH V2 net] net: fec: Coverity issue: Dereference null return value > -----Original Message----- > From: Jakub Kicinski <kuba@...nel.org> > Sent: 2022年12月21日 3:36 > To: Wei Fang <wei.fang@....com> > Cc: davem@...emloft.net; edumazet@...gle.com; pabeni@...hat.com; > Clark Wang <xiaoning.wang@....com>; Shenwei Wang > <shenwei.wang@....com>; alexander.duyck@...il.com; dl-linux-imx > <linux-imx@....com>; netdev@...r.kernel.org; linux-kernel@...r.kernel.org > Subject: Re: [PATCH V2 net] net: fec: Coverity issue: Dereference null return > value > > On Mon, 19 Dec 2022 10:27:55 +0800 wei.fang@....com wrote: > > From: Wei Fang <wei.fang@....com> > > > > The build_skb might return a null pointer but there is no check on the > > return value in the fec_enet_rx_queue(). So a null pointer dereference > > might occur. To avoid this, we check the return value of build_skb. If > > the return value is a null pointer, the driver will recycle the page > > and update the statistic of ndev. Then jump to rx_processing_done to > > clear the status flags of the BD so that the hardware can recycle the BD. > > Applied but I had to change the subject because the subject should describe > the change. Mentioning the tool which found the problem belongs in the body > of the message. Thanks for taking the time to make these changes, I'll keep these things in mind next time.
Powered by blists - more mailing lists