lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 21 Dec 2022 02:41:50 +0100 From: Andrew Lunn <andrew@...n.ch> To: Rob Herring <robh@...nel.org> Cc: Christian Marangi <ansuelsmth@...il.com>, Florian Fainelli <f.fainelli@...il.com>, Vladimir Oltean <olteanv@...il.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Jonathan Corbet <corbet@....net>, Pavel Machek <pavel@....cz>, "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>, John Crispin <john@...ozen.org>, netdev@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org, linux-leds@...r.kernel.org, Tim Harvey <tharvey@...eworks.com>, Alexander Stein <alexander.stein@...tq-group.com>, Rasmus Villemoes <rasmus.villemoes@...vas.dk> Subject: Re: [PATCH v7 11/11] dt-bindings: net: dsa: qca8k: add LEDs definition example > > > + }; > > > + > > > + led@1 { > > > + reg = <1>; > > > + color = <LED_COLOR_ID_AMBER>; > > > + function = LED_FUNCTION_LAN; > > > + function-enumerator = <1>; > > > > Typo? These are supposed to be unique. Can't you use 'reg' in your case? > > reg in this context is the address of the PHY on the MDIO bus. This is > an Ethernet switch, so has many PHYs, each with its own address. Actually, i'm wrong about that. reg in this context is the LED number of the PHY. Typically there are 2 or 3 LEDs per PHY. There is no reason the properties need to be unique. Often the LEDs have 8 or 16 functions, identical for each LED, but with different reset defaults so they show different things. Andrew
Powered by blists - more mailing lists