netdev - Re: [PATCH bpf 1/2] bpf: pull before calling skb_postpull

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 21 Dec 2022 00:20:15 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     daniel@...earbox.net, bpf@...r.kernel.org, netdev@...r.kernel.org,
        anpartha@...a.com, martin.lau@...ux.dev, song@...nel.org,
        john.fastabend@...il.com, sdf@...gle.com
Subject: Re: [PATCH bpf 1/2] bpf: pull before calling skb_postpull_rcsum()

Hello:

This series was applied to bpf/bpf.git (master)
by Martin KaFai Lau <martin.lau@...nel.org>:

On Mon, 19 Dec 2022 16:47:00 -0800 you wrote:
> Anand hit a BUG() when pulling off headers on egress to a SW tunnel.
> We get to skb_checksum_help() with an invalid checksum offset
> (commit d7ea0d9df2a6 ("net: remove two BUG() from skb_checksum_help()")
> converted those BUGs to WARN_ONs()).
> He points out oddness in how skb_postpull_rcsum() gets used.
> Indeed looks like we should pull before "postpull", otherwise
> the CHECKSUM_PARTIAL fixup from skb_postpull_rcsum() will not
> be able to do its job:
> 
> [...]

Here is the summary with links:
  - [bpf,1/2] bpf: pull before calling skb_postpull_rcsum()
    https://git.kernel.org/bpf/bpf/c/54c3f1a81421
  - [bpf,2/2] selftests/bpf: tunnel: add sanity test for checksums
    (no matching commit)

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html