lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 21 Dec 2022 17:43:58 +0800 From: Xu Liang <lxu@...linear.com> To: <andrew@...n.ch>, <hkallweit1@...il.com>, <netdev@...r.kernel.org>, <davem@...emloft.net>, <kuba@...nel.org> CC: <linux@...linux.org.uk>, <hmehrtens@...linear.com>, <tmohren@...linear.com>, <mohammad.athari.ismail@...el.com>, <edumazet@...gle.com>, <pabeni@...hat.com>, Xu Liang <lxu@...linear.com> Subject: [PATCH net v2] net: phy: mxl-gpy: fix delay time required by loopback disable function GPY2xx devices need 3 seconds to fully switch out of loopback mode before it can safely re-enter loopback mode. Signed-off-by: Xu Liang <lxu@...linear.com> --- drivers/net/phy/mxl-gpy.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/mxl-gpy.c b/drivers/net/phy/mxl-gpy.c index 147d7a5a9b35..b682d7fc477c 100644 --- a/drivers/net/phy/mxl-gpy.c +++ b/drivers/net/phy/mxl-gpy.c @@ -770,9 +770,11 @@ static int gpy_loopback(struct phy_device *phydev, bool enable) enable ? BMCR_LOOPBACK : 0); if (!ret) { /* It takes some time for PHY device to switch - * into/out-of loopback mode. + * into/out-of loopback mode. It takes 3 seconds + * to fully switch out of loopback mode before + * it can safely re-enter loopback mode. */ - msleep(100); + msleep(enable ? 100 : 3000); } return ret; -- 2.17.1
Powered by blists - more mailing lists