netdev - Re: [PATCH net v2] net: phy: mxl-gpy: fix delay time required by loopback disable function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y6L6X2w5EdUBq5ON@shell.armlinux.org.uk>
Date:   Wed, 21 Dec 2022 12:21:51 +0000
From:   "Russell King (Oracle)" <linux@...linux.org.uk>
To:     Xu Liang <lxu@...linear.com>
Cc:     andrew@...n.ch, hkallweit1@...il.com, netdev@...r.kernel.org,
        davem@...emloft.net, kuba@...nel.org, hmehrtens@...linear.com,
        tmohren@...linear.com, mohammad.athari.ismail@...el.com,
        edumazet@...gle.com, pabeni@...hat.com
Subject: Re: [PATCH net v2] net: phy: mxl-gpy: fix delay time required by
 loopback disable function

Hi,

On Wed, Dec 21, 2022 at 05:43:58PM +0800, Xu Liang wrote:
> GPY2xx devices need 3 seconds to fully switch out of loopback mode
> before it can safely re-enter loopback mode.

Would it be better to record the time that loopback mode is exited,
and then delay an attempt to re-enter loopback mode if it's less than
three seconds since we exited?

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!